Format comment directive improvements #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split over multiple lines, order entries alphabetically, avoid unnecessary capturing groups for tiny performance gain. Moves NOSONAR to inside the "correct" set of parenthesis, with no functional effect though.
https://github.com/securego/gosec#annotating-code Incidentally, #nosec was already mostly treated as a comment directive due to another check done after the regex match. This just makes it explicit and adds related test cases. Some versions of gosec also support the //gosec:disable directive, but that's quite well hidden in docs compared to //#nosec.
mvdan
approved these changes
Aug 12, 2025
Owner
mvdan
left a comment
mvdan
left a comment
There was a problem hiding this comment.
Thanks! Appreciate the commit messages.
Closed
mvdan
pushed a commit
that referenced
this pull request
Sep 4, 2025
Restores previous directive regexp expectations. Related to #327. Fixes $331.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.